Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision product search tests #1202

Conversation

nirupa-kumar
Copy link
Contributor

@nnegrey Please review.
Fixed the Product Search test (needs existing indexed product set). Also added the additional files that needed Inc. -> LLC

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2018
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtisvg kurtisvg requested a review from a team February 8, 2019 17:59
@kurtisvg
Copy link
Contributor

kurtisvg commented Feb 8, 2019

@nirupa-kumar @nnegrey The tests for these changes are failing - can we either fix them or close the PR if the changes are no longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants