Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions.ExampleSystemTest: helloHttp_shouldRunWithFunctionsFramework failed #2928

Closed
flaky-bot bot opened this issue May 19, 2020 · 9 comments · Fixed by #2984
Closed

functions.ExampleSystemTest: helloHttp_shouldRunWithFunctionsFramework failed #2928

flaky-bot bot opened this issue May 19, 2020 · 9 comments · Fixed by #2984
Assignees
@ace-n
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 19, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

commit: 94061b1
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 19, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented May 20, 2020

commit: d02178b
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@flaky-bot
Copy link
Author

flaky-bot bot commented May 21, 2020

commit: ff7ed6b
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@flaky-bot
Copy link
Author

flaky-bot bot commented May 22, 2020

commit: 69dee00
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@flaky-bot
Copy link
Author

flaky-bot bot commented May 23, 2020

commit: 0870bb8
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@flaky-bot
Copy link
Author

flaky-bot bot commented May 26, 2020

commit: a18f774
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 26, 2020
@lesv lesv added the api: cloudfunctions Issues related to the Cloud Run functions API. label May 26, 2020
@lesv lesv assigned ace-n and unassigned dzlier-gcp May 26, 2020
@lesv lesv removed the 🚨 This issue needs some love. label May 26, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 26, 2020
@ace-n ace-n mentioned this issue May 26, 2020
Closed
@flaky-bot
Copy link
Author

flaky-bot bot commented May 27, 2020

commit: f5fcf50
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@ace-n
Copy link
Contributor

ace-n commented May 27, 2020

This is an issue with our testing project configuration, not the sample itself. (@lesv @kurtisvg @averikitsch see my email internally.)

@ace-n ace-n added priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 27, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label May 27, 2020
@kurtisvg kurtisvg added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. labels May 27, 2020
@kurtisvg
Copy link
Contributor

I followed Ace's instructions and deployed a function and updated the FUNCTIONS_BASE_URL. I'll close this bug for now and let it reopen if the tests fail.

@flaky-bot flaky-bot bot reopened this May 28, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented May 28, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

commit: 7435c04
buildURL: Build Status, Sponge
status: failed

Test output
expected: Hello world!
but was an empty string
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:47)

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 28, 2020
@kurtisvg kurtisvg mentioned this issue May 28, 2020
Merged
7 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue May 28, 2020
@kurtisvg
Update ExampleSystemTest.java (#2984)
db7dc84 
Fixes #2928 

> It's a good idea to open an issue first for discussion.

- [x] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md)
- [x] `pom.xml` parent set to latest `shared-configuration`
- [ ] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
- [ ] Tests pass (`mvn -P lint clean verify`)
  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
- [x] Please **merge** this PR for me once it is approved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
5 participants
@lesv @ace-n @kurtisvg @dzlier-gcp @yoshi-automation