Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dcm4che to 5.31.2 #165

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Update dcm4che to 5.31.2 #165

merged 1 commit into from
Mar 8, 2024
+118 −141

Conversation

IvanIsCoding
Copy link
Collaborator

This PR:

  • Updates dcm4che from 5.18.1 to 5.31.2
  • Refactors integration tests to not depend on maven and use binaries provided by dcm4che
  • Adds a diff that ignores the implementation version name tag, which causes the integration tests to fail if we change the dcm4che version

@IvanIsCoding
Copy link
Collaborator Author

/gcbrun

2 similar comments
@danielbeaudreau
Copy link
Collaborator

/gcbrun

@IvanIsCoding
Copy link
Collaborator Author

/gcbrun

@IvanIsCoding IvanIsCoding requested a review from lnogueir March 8, 2024 18:33
@danielbeaudreau danielbeaudreau merged commit db75093 into GoogleCloudPlatform:master Mar 8, 2024
3 checks passed
@IvanIsCoding IvanIsCoding deleted the dcm4che-and-integration-tests branch March 8, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnogueir lnogueir Awaiting requested review from lnogueir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanIsCoding @danielbeaudreau