-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIT: Support SSH connections to hosts that block SHA1 #442
Conversation
/hold so the main issue here is we need to confirm changing the shared go.mod doesn't break any of the containers, and if it does, we'll have to create per-project go modules either for the old or the new |
This PR creates a new go.mod and leaves the old one unchanged. :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EricEdens, hopkiw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
The container build configurations were changed in GoogleCloudPlatform#442. These instructions need to be updated to handle this.
The container build configurations were changed in #442. These instructions need to be updated to handle this.
* Update container build instructions The container build configurations were changed in #442. These instructions need to be updated to handle this. * Remvoe gcs-key.credential for partner-image-export Co-authored-by: Neil Patel <[email protected]>
* Update container build instructions The container build configurations were changed in #442. These instructions need to be updated to handle this. * Remove 81 and add 93,97 COS images Co-authored-by: Neil Patel <[email protected]>
The SSH tests in CIT use Go to establish SSH connections:
guest-test-infra/imagetest/utils/test_utils.go
Line 192 in 99181c4
While running CIT against Ubuntu 22.04, I observed that the SSH tests were failing:
This occurred since Ubuntu 22.04 updated to an OpenSSH version that blocks connections that use SHA-1: https://www.openssh.com/releasenotes.html
This PR updates the
golang.org/x/crypto
dependency, which brings in their PR to support SHA-2 keys: golang/go#37278It also does the following:
imagetest
directory