Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition where pending Ack IDs can be modified by another thread. #5929

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Fix race condition where pending Ack IDs can be modified by another thread. #5929

merged 1 commit into from
Sep 12, 2018

Conversation

theacodes
Copy link
Contributor

Closes #5913

@theacodes theacodes requested a review from tseaver September 11, 2018 19:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

I kicked off a rebuild, hoping to work around the logging systest failure.

@theacodes theacodes force-pushed the fix-ack-id-race-condition branch from c6dc8fd to 3ea88a5 Compare September 11, 2018 21:08
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Sep 11, 2018
@tseaver tseaver force-pushed the fix-ack-id-race-condition branch from 3ea88a5 to 949604c Compare September 11, 2018 22:16
@ghost
Copy link

ghost commented Sep 12, 2018

apologies if I am out of line, but will this make it into the 0.38.0 release? (#5962)

@theacodes
Copy link
Contributor Author

Oh good catch, @jordanhurwitz! I thought this was merged.

@theacodes theacodes merged commit f074335 into master Sep 12, 2018
@theacodes theacodes deleted the fix-ack-id-race-condition branch September 12, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theacodes @tseaver @googlebot