Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making sure that benchmarking tests are run for periodic tests only #2992

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

anushka567
Copy link
Member

@anushka567 anushka567 commented Feb 11, 2025

Description

  • Tests in the benchmarking test package will be skipped in case the presubmit flag is turned on.
  • Clean up for the cd scripts.
  • In a follow-up PR, I will adjust the thresholds value based on periodic test region which is now us-west4.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Automated

@anushka567 anushka567 marked this pull request as ready for review February 11, 2025 07:55
@anushka567 anushka567 requested review from Tulsishah and a team as code owners February 11, 2025 07:55
@kislaykishore kislaykishore requested review from a team, tritone, BrennaEpp and gargnitingoogle and removed request for a team, tritone and BrennaEpp February 11, 2025 07:56
@anushka567 anushka567 added the execute-integration-tests Run only integration tests label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.24%. Comparing base (96dbe39) to head (8bc7a90).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
- Coverage   75.29%   75.24%   -0.06%     
==========================================
  Files         125      125              
  Lines       17736    17736              
==========================================
- Hits        13355    13345      -10     
- Misses       3815     3823       +8     
- Partials      566      568       +2     
Flag Coverage Δ
unittests 75.24% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gargnitingoogle gargnitingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/integration_tests/run_e2e_tests.sh Outdated Show resolved Hide resolved
@kislaykishore kislaykishore requested review from a team and tritone and removed request for a team February 11, 2025 10:27
@anushka567 anushka567 enabled auto-merge (squash) February 11, 2025 12:57
@anushka567 anushka567 merged commit 114a94e into master Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants