Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes retry for control client #2539

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

ankitaluthra1
Copy link
Collaborator

Description

Separates retry for control client from data client | increses timeout for retry | adds more error code for retry in control client

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - done
  3. Integration tests - NA

…t for retry | adds more error code for retry in control client
@ankitaluthra1 ankitaluthra1 added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (b908a3c) to head (392f5a8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/storage/storageutil/control_client.go 14.28% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
- Coverage   78.81%   78.35%   -0.46%     
==========================================
  Files         106      107       +1     
  Lines       11695    11776      +81     
==========================================
+ Hits         9217     9227      +10     
- Misses       2001     2066      +65     
- Partials      477      483       +6     
Flag Coverage Δ
unittests 78.35% <14.28%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankitaluthra1 ankitaluthra1 marked this pull request as ready for review September 27, 2024 04:52
@ankitaluthra1 ankitaluthra1 requested a review from a team as a code owner September 27, 2024 04:52
@kislaykishore kislaykishore requested review from a team, kislaykishore, BrennaEpp and gargnitingoogle and removed request for a team, kislaykishore, BrennaEpp and gargnitingoogle September 27, 2024 04:52
@ankitaluthra1 ankitaluthra1 removed request for BrennaEpp and a team September 27, 2024 04:53
@kislaykishore kislaykishore requested review from gargnitingoogle, a team and BrennaEpp and removed request for gargnitingoogle and BrennaEpp September 27, 2024 04:53
@ankitaluthra1 ankitaluthra1 removed the request for review from gargnitingoogle September 27, 2024 06:38
@ankitaluthra1 ankitaluthra1 merged commit 01d2308 into master Sep 27, 2024
11 of 12 checks passed
@ankitaluthra1 ankitaluthra1 deleted the control-client-retry-fix branch September 27, 2024 08:58
ashmeenkaur pushed a commit that referenced this pull request Oct 9, 2024
* separates retry for control client from data client | increses timeout for retry | adds more error code for retry in control client

* removes create and delete methods for retry in folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants