Categorize errors into groups #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
force-pushed
the
error-type-grp
branch
2 times, most recently
from
a78d277 to
f481507
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2321 +/- ##
==========================================
- Coverage 79.54% 78.91% -0.64%
==========================================
Files 106 106
Lines 11524 12618 +1094
==========================================
+ Hits 9167 9957 +790
- Misses 1920 2187 +267
- Partials 437 474 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
force-pushed
the
error-type-grp
branch
3 times, most recently
from
3b740ee to
c17a6c7
Compare
sethiay
reviewed
Aug 12, 2024
kislaykishore
force-pushed
the
error-type-grp
branch
from
c17a6c7 to
5184b74
Compare
This helps reduce the cardinality of the labels which is required so that Cloud Metrics pipeline doesn't drop the labels. We need to keep this cardinality below 30.
kislaykishore
force-pushed
the
error-type-grp
branch
from
cc8a430 to
b61d9e7
Compare
sethiay
previously approved these changes
Aug 14, 2024
sethiay
previously approved these changes
Aug 14, 2024
sethiay
reviewed
Aug 14, 2024
sethiay
approved these changes
Aug 14, 2024
ashmeenkaur
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Categorize errors into groups This helps reduce the cardinality of the labels which is required so that Cloud Metrics pipeline doesn't drop the labels. We need to keep this cardinality below 30.
ashmeenkaur
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Categorize errors into groups This helps reduce the cardinality of the labels which is required so that Cloud Metrics pipeline doesn't drop the labels. We need to keep this cardinality below 30.
ashmeenkaur
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Categorize errors into groups This helps reduce the cardinality of the labels which is required so that Cloud Metrics pipeline doesn't drop the labels. We need to keep this cardinality below 30.
kislaykishore
added a commit
that referenced
this pull request
Aug 21, 2024
* Categorize errors into groups This helps reduce the cardinality of the labels which is required so that Cloud Metrics pipeline doesn't drop the labels. We need to keep this cardinality below 30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce the cardinality of the labels to 17 which is required so that Cloud Metrics pipeline doesn't drop the labels. We need to keep this cardinality below 30.
Description
Link to the issue in case of a bug fix.
NA
Testing details