Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation around Dockerfiles #70

Merged
merged 4 commits into from
Jul 16, 2020

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Jul 15, 2020

  • Fix the inline example in the cloud-run-http
  • Add a link to this sample Dockerfile in the main README

examples/cloud_run_http/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
glasnt added 2 commits July 16, 2020 08:25
Useful for when this readme appears on both github and pypi
@di di merged commit 95d0b35 into GoogleCloudPlatform:master Jul 16, 2020
@di
Copy link
Member

di commented Jul 16, 2020

Thanks!

di pushed a commit that referenced this pull request Aug 11, 2020
* Add a link to an example Dockerfile in the top README.md

* Update the inline Dockerfile to match file

* Remove explicit gunicorn installation

* make readme links absolute, useful

Useful for when this readme appears on both github and pypi
di added a commit that referenced this pull request Oct 22, 2020
* Version 1.5.0 (#69)

* Revert "Version 2.0.0 (#67)"

This reverts commit f2471b4.

* Revert "Add Cloud Events support for #55 (#56) (#64)"

This reverts commit 8f3fe35.

* Version 1.5.0

* Improve documentation around Dockerfiles (#70)

* Add a link to an example Dockerfile in the top README.md

* Update the inline Dockerfile to match file

* Remove explicit gunicorn installation

* make readme links absolute, useful

Useful for when this readme appears on both github and pypi

* added cloudevents 1.0.0

Signed-off-by: Curtis Mason <[email protected]>

* reverted auto format

Signed-off-by: Curtis Mason <[email protected]>

* lint fixes

Signed-off-by: Curtis Mason <[email protected]>

* changed cloudevents to <=1.0 in setup

Signed-off-by: Curtis Mason <[email protected]>

* made cloudevents==1.0

Signed-off-by: Curtis Mason <[email protected]>

* added cloudevent_view tests

Signed-off-by: Curtis Mason <[email protected]>

* test lint fixes

Signed-off-by: Curtis Mason <[email protected]>

* implemented try_catch in cloudevent view wrapper

Signed-off-by: Curtis Mason <[email protected]>

* import fix

Signed-off-by: Curtis Mason <[email protected]>

* adjusted cloud_run_cloudevents readme

Signed-off-by: Curtis Mason <[email protected]>

* added elif for cloudevent

Signed-off-by: Curtis Mason <[email protected]>

* adjusted README

Signed-off-by: Curtis Mason <[email protected]>

* upgraded to cloudevents 1.0.1

Signed-off-by: Curtis Mason <[email protected]>

* import ordering lint fix

Signed-off-by: Curtis Mason <[email protected]>

* removed event from readme cloudevents section

Signed-off-by: Curtis Mason <[email protected]>

* resolved various nits and reverted event code

Signed-off-by: Curtis Mason <[email protected]>

* dockerfile env variables

Signed-off-by: Curtis Mason <[email protected]>

* Update examples/cloud_run_cloudevents/main.py

Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>

* cleaned up test_cloudevent_functions

Signed-off-by: Curtis Mason <[email protected]>

* Update examples/cloud_run_cloudevents/Dockerfile

Co-authored-by: Adam Ross <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>

* tunneled cloud_exceptions in flask abort

Signed-off-by: Curtis Mason <[email protected]>

* Added additional documentation in sample code

Signed-off-by: Curtis Mason <[email protected]>

* added time to tests

Signed-off-by: Curtis Mason <[email protected]>

* Update README.md

Co-authored-by: Dustin Ingram <[email protected]>

* Update README.md

Co-authored-by: Dustin Ingram <[email protected]>

* Update README.md

Co-authored-by: Dustin Ingram <[email protected]>

* Update README.md

Co-authored-by: Dustin Ingram <[email protected]>

* Update examples/cloud_run_cloudevents/send_cloudevent.py

Co-authored-by: Dustin Ingram <[email protected]>

* Update examples/cloud_run_cloudevents/README.md

Co-authored-by: Dustin Ingram <[email protected]>

* Update examples/cloud_run_cloudevents/README.md

Co-authored-by: Dustin Ingram <[email protected]>

* Update src/functions_framework/__init__.py

Co-authored-by: Dustin Ingram <[email protected]>

* Update src/functions_framework/__init__.py

Co-authored-by: Dustin Ingram <[email protected]>

* cloudevents 1.1.0 update

Signed-off-by: Curtis Mason <[email protected]>

* simplified exceptions debug

Signed-off-by: Curtis Mason <[email protected]>

* simplified cloudevent view test

Signed-off-by: Curtis Mason <[email protected]>

* Update src/functions_framework/__init__.py

Co-authored-by: Dustin Ingram <[email protected]>

* shebang cloudevent executable

Signed-off-by: Curtis Mason <[email protected]>

* cloudevents version bump

Signed-off-by: Curtis Mason <[email protected]>

* Removed InvalidStructuredJSON exception

Signed-off-by: Curtis Mason <[email protected]>

* Don't bump version in a feature branch

* Add back missing CHANGELOG lines

* Reformat with latest black

Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Katie McLaughlin <[email protected]>
Co-authored-by: Adam Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants