-
Notifications
You must be signed in to change notification settings - Fork 117
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Support strongly typed functions signature (#208)
- Loading branch information
1 parent
f013ab4
commit aa59a6b
Showing
11 changed files
with
653 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
import inspect | ||
|
||
from inspect import signature | ||
|
||
from functions_framework import _function_registry | ||
from functions_framework.exceptions import FunctionsFrameworkException | ||
|
||
"""Registers user function in the REGISTRY_MAP and the INPUT_TYPE_MAP. | ||
Also performs some validity checks for the input type of the function | ||
Args: | ||
decorator_type: The type provided by the @typed(input_type) decorator | ||
func: User function | ||
""" | ||
|
||
|
||
def register_typed_event(decorator_type, func): | ||
try: | ||
sig = signature(func) | ||
annotation_type = list(sig.parameters.values())[0].annotation | ||
input_type = _select_input_type(decorator_type, annotation_type) | ||
_validate_input_type(input_type) | ||
except IndexError: | ||
raise FunctionsFrameworkException( | ||
"Function signature is missing an input parameter." | ||
"The function should be defined as 'def your_fn(in: inputType)'" | ||
) | ||
except Exception as e: | ||
raise FunctionsFrameworkException( | ||
"Functions using the @typed decorator must provide " | ||
"the type of the input parameter by specifying @typed(inputType) and/or using python " | ||
"type annotations 'def your_fn(in: inputType)'" | ||
) | ||
|
||
_function_registry.INPUT_TYPE_MAP[func.__name__] = input_type | ||
_function_registry.REGISTRY_MAP[ | ||
func.__name__ | ||
] = _function_registry.TYPED_SIGNATURE_TYPE | ||
|
||
|
||
""" Checks whether the response type of the typed function has a to_dict method""" | ||
|
||
|
||
def _validate_return_type(response): | ||
if not (hasattr(response, "to_dict") and callable(getattr(response, "to_dict"))): | ||
raise AttributeError( | ||
"The type {response} does not have the required method called " | ||
" 'to_dict'.".format(response=type(response)) | ||
) | ||
|
||
|
||
"""Selects the input type for the typed function provided through the @typed(input_type) | ||
decorator or through the parameter annotation in the user function | ||
""" | ||
|
||
|
||
def _select_input_type(decorator_type, annotation_type): | ||
if decorator_type == None and annotation_type is inspect._empty: | ||
raise TypeError( | ||
"The function defined does not contain Type of the input object." | ||
) | ||
|
||
if ( | ||
decorator_type != None | ||
and annotation_type is not inspect._empty | ||
and decorator_type != annotation_type | ||
): | ||
raise TypeError( | ||
"The object type provided via 'typed' decorator: '{decorator_type}'" | ||
"is different than the one specified by the function parameter's type annotation : '{annotation_type}'.".format( | ||
decorator_type=decorator_type, annotation_type=annotation_type | ||
) | ||
) | ||
|
||
if decorator_type == None: | ||
return annotation_type | ||
return decorator_type | ||
|
||
|
||
"""Checks for the from_dict method implementation in the input type class""" | ||
|
||
|
||
def _validate_input_type(input_type): | ||
if not ( | ||
hasattr(input_type, "from_dict") and callable(getattr(input_type, "from_dict")) | ||
): | ||
raise AttributeError( | ||
"The type {decorator_type} does not have the required method called " | ||
" 'from_dict'.".format(decorator_type=input_type) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Function used to test handling functions using typed decorators.""" | ||
|
||
import flask | ||
|
||
import functions_framework | ||
|
||
|
||
class TestType1: | ||
name: str | ||
age: int | ||
|
||
def __init__(self, name: str, age: int) -> None: | ||
self.name = name | ||
self.age = age | ||
|
||
|
||
class TestType2: | ||
name: str | ||
|
||
def __init__(self, name: str) -> None: | ||
self.name = name | ||
|
||
|
||
@functions_framework.typed(TestType2) | ||
def function_typed_mismatch_types(test_type: TestType1): | ||
valid_event = test_type.name == "john" and test_type.age == 10 | ||
if not valid_event: | ||
raise Exception("Received invalid input") | ||
return test_type |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Function used to test handling functions using typed decorators.""" | ||
from typing import Any, TypeVar | ||
|
||
import flask | ||
|
||
import functions_framework | ||
|
||
T = TypeVar("T") | ||
|
||
|
||
def from_str(x: Any) -> str: | ||
assert isinstance(x, str) | ||
return x | ||
|
||
|
||
def from_int(x: Any) -> int: | ||
assert isinstance(x, int) and not isinstance(x, bool) | ||
return x | ||
|
||
|
||
class TestTypeMissingFromDict: | ||
name: str | ||
age: int | ||
|
||
def __init__(self, name: str, age: int) -> None: | ||
self.name = name | ||
self.age = age | ||
|
||
def to_dict(self) -> dict: | ||
result: dict = {} | ||
result["name"] = from_str(self.name) | ||
result["age"] = from_int(self.age) | ||
return result | ||
|
||
|
||
@functions_framework.typed(TestTypeMissingFromDict) | ||
def function_typed_missing_from_dict(test_type: TestTypeMissingFromDict): | ||
valid_event = test_type.name == "john" and test_type.age == 10 | ||
if not valid_event: | ||
raise Exception("Received invalid input") | ||
return test_type |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Function used to test handling functions using typed decorators.""" | ||
import flask | ||
|
||
import functions_framework | ||
|
||
|
||
@functions_framework.typed | ||
def function_typed_missing_type_information(): | ||
print("hello") |
Oops, something went wrong.