fix: etag should not be set on any response (#571)

GoogleCloudPlatform · Sep 28, 2023 · 89a3abb · 89a3abb
1 parent 9aebc3a
commit 89a3abb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/server.ts b/src/server.ts
@@ -108,7 +108,7 @@ export function getServer(
   app.disable('x-powered-by');
 
   // Disable Express eTag response header
-  app.disable('etag');
+  app.set('etag', false);
 
   if (
     functionSignatureType === 'event' ||

diff --git a/test/integration/http.ts b/test/integration/http.ts
@@ -105,7 +105,8 @@ describe('HTTP Function', () => {
       )
         .set('Content-Type', 'application/json')
         .expect(test.expectedBody)
-        .expect(test.expectedStatus);
+        .expect(test.expectedStatus)
+        .expect(res => assert(!res.get('etag')));
       assert.strictEqual(callCount, test.expectedCallCount);
     });
   });