Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore-vector-search): allow array values for prefilter #515

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

Harlan-Epoch
Copy link

Currently if you try to use the "in" operator with an array value in a prefilter you get an invalid argument error. By updating line 20 like I have, the function now accepts the array.

cabljac and others added 2 commits May 30, 2024 13:57
Currently if you try to use the "in" operator with an array value in a prefilter you get an invalid argument error. By updating line 20 like I have the function now accepts the array.
@pr-Mais pr-Mais changed the title docs(ext-firestore-vector-search-queryCallable) updated Utils.ts fix(firestore-vector-search): allow array values for prefilter Jun 7, 2024
@InvokeInnovationsInc
Copy link

im excited for this! I was wondering why I couldn't do this

@Harlan-Epoch
Copy link
Author

Harlan-Epoch commented Jun 14, 2024

im excited for this! I was wondering why I couldn't do this

Hey! Well if you don't mind managing it yourself you can edit the source code in your google console to exactly what I commented and it will work. Not sure why it didn't pass the tests. I'm running it in production with no errors. You can add functionality for booleans as well in the same line.

@Juraj333
Copy link

im excited for this! I was wondering why I couldn't do this
Well, I can't pass the test for beginner developers

@GoogleCloudPlatform GoogleCloudPlatform deleted a comment from Juraj333 Jun 17, 2024
@pr-Mais
Copy link
Collaborator

pr-Mais commented Jul 31, 2024

@Harlan-Epoch thanks for adding this! tests seems to be failing, could you check and apply necessary updates.

@cabljac cabljac force-pushed the next branch 2 times, most recently from 4a4eb88 to d401bbd Compare November 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants