fix(bigquery-firestore-export): avoid the setup getting stuck #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(firestore-semantic-search): neighbor_count parameter incorrect location
* feat(firestore-multimodal-genai): add callable function * refactor(firestore-multimodal-genai): tidy some code up a little
…transfer config is not found
|
Can we add tests |
|
@pr-Mais added a new test |
cabljac
force-pushed
the
next
branch
2 times, most recently
from
6ba1398 to
f6c5ee3
Compare
…e-extensions into @invertase/bq-fs-export-transfer-config
pr-Mais
pushed a commit
that referenced
this pull request
May 8, 2024
* docs(*): add gemini docs on regions * fix(firestore-semantic-search): neighbor_count parameter location (#391) * fix(firestore-semantic-search): neighbor_count parameter incorrect location * feat(firestore-multimodal-genai): add callable function (#422) * feat(firestore-multimodal-genai): add callable function * refactor(firestore-multimodal-genai): tidy some code up a little * docs: remove reference to VARIABLE_FIELDS (#421) * chore(firestore-multimodal-genai): bump extension version * fix(bigquery-firestore-export): avoid the setup getting stuck if the transfer config is not found * feat(bigquery-firestore-export): transferConfig not found test --------- Co-authored-by: Jacob Cable <[email protected]> Co-authored-by: Jacob Cable <[email protected]>
|
Is there a release scheduled with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the extension setup process gets stuck if the transfer config collection is provided, transfer config name is found, but the config itself does not exist.
Resolves #411.