Add controller save state disk #3661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssa-sm
added
the
release-key-new-features
mr0re1
reviewed
Feb 11, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
| content { | ||
| source = google_compute_disk.controller_state_disk[0].id | ||
| mode = "READ_WRITE" | ||
| device_name = "${local.slurm_cluster_name}-controller-state" |
There was a problem hiding this comment.
nit. Is there a particular reason to give "uniq" name to the device? Not objection, just curious.
mr0re1
reviewed
Feb 11, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
...unity/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Feb 11, 2025
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Outdated
Show resolved
Hide resolved
alyssa-sm
force-pushed
the
disk-save-state
branch
4 times, most recently
from
477f527 to
362adae
Compare
alyssa-sm
force-pushed
the
disk-save-state
branch
from
362adae to
7e8e622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a state save disk for the controller. With this implementation, slurm information saved on the controller will persist even if the controller were to be destroyed.