Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure 2-Party Review on Github PRs from External Contributors #3660

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RachaelSTamakloe
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe commented Feb 10, 2025

This PR adds a workflow that configures 2-Party Review on PRs from External Contributors. It will require a single employee approval from employee created PRs, but require two employees to approve for non-Googler PRs. This PR depends on PR3662 being merged.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe self-assigned this Feb 10, 2025
@RachaelSTamakloe RachaelSTamakloe force-pushed the 2PR branch 2 times, most recently from d058230 to 6fb866e Compare February 10, 2025 21:34
@RachaelSTamakloe RachaelSTamakloe marked this pull request as ready for review February 11, 2025 23:39
@RachaelSTamakloe RachaelSTamakloe added the release-chore To not include into release notes label Feb 11, 2025
@rohitramu rohitramu removed their assignment Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants