Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provisioningModel for calendar future reservations #3592

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add provisioningModel for calendar future reservations #3592

wants to merge 1 commit into from
+9 −4

Conversation

abbas1902
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-chore To not include into release notes label Jan 27, 2025
@abbas1902 abbas1902 requested a review from mr0re1 January 27, 2025 19:31
@abbas1902 abbas1902 assigned mr0re1 and abbas1902 and unassigned mr0re1 Jan 27, 2025
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Jan 27, 2025
mr0re1
mr0re1 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@mr0re1 mr0re1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary LGTM. Before landing, please get certainty on topic we discussed offline.

@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@abbas1902 abbas1902

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbas1902 @mr0re1