Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set automaticRestart: false #2981

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Don't set automaticRestart: false #2981

merged 1 commit into from
Aug 30, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Aug 29, 2024

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mr0re1 mr0re1 added the release-improvements Added to release notes under the "Improvements" heading. label Aug 29, 2024
@mr0re1 mr0re1 self-assigned this Aug 29, 2024
@mr0re1 mr0re1 requested a review from nick-stroud August 29, 2024 04:59
@mr0re1 mr0re1 assigned nick-stroud and unassigned mr0re1 Aug 29, 2024
@nick-stroud nick-stroud assigned mr0re1 and unassigned nick-stroud Aug 30, 2024
@mr0re1 mr0re1 merged commit eefdca5 into GoogleCloudPlatform:develop Aug 30, 2024
10 of 53 checks passed
@mr0re1 mr0re1 deleted the autoRest branch August 30, 2024 20:33
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@mr0re1 mr0re1

Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr0re1 @nick-stroud