Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFE - various updates and fixes #2921

Merged
merged 51 commits into from
Aug 14, 2024
Merged

OFE - various updates and fixes #2921

merged 51 commits into from
Aug 14, 2024

Conversation

scott-nag
Copy link
Collaborator

OFE fixes and updates:

  • Upgrade to use Slurm-GCP v6 modules instead of v5
  • Migrated to Rocky8
  • Use Terraform 1.4 (Using a newer version of Terraform can lead to controller replacement on reconfigure for Slurm GCP v6 #2774)
  • Added validation for clusters that use reservations. It validates whether:
    • reservation exists in the project, region and zone
    • reservation supports the selected node type
    • reservation has capacity for the requested instances
    • reservation is 'specific'
  • Added support to display disk type options which are valid for the selected machine type
  • Changed mentions of ‘hpc-toolkit’ to ‘cluster-toolkit’

ek-nag and others added 30 commits June 17, 2024 13:54
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
f3d16d0
@ek-nag
OFE: adding missing APIs for image creation functionality
b4289f8
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
8e7a068
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
57851b5
@ek-nag
OFE: Update update_form.html
7d85a8a 
Typo in cluster additional disk javascript.
@ek-nag
OFE: Update clusterinfo.py
dc81f68 
Fixing the logic for selecting custom images for controller and login nodes.
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
2fb0cbe
@ek-nag
OFE Update update_form.html
dace639 
Fixing disk selection for login and controller nodes logic
@ek-nag
OFE: Update cluster_config.yaml.j2
226dc67 
Migrating to V6
@ek-nag
OFE: Update partition_config.yaml.j2
aca482e 
Migrating to V6
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
e6285b1
@ek-nag
OFE: Update clusterinfo.py
74c9d42 
Migrating to V6
@ek-nag
OFE: Update models.py
7ead9ad 
Migrating to V6
@ek-nag
OFE: Update bootstrap_compute.sh
555292d 
Migrating to v6
@ek-nag
OFE: Update bootstrap_controller.sh
b00317b 
Migrating to v6
@ek-nag
OFE: Update bootstrap_login.sh
00f8c9d 
Migrating to v6
@ek-nag
OFE: Update main.yaml
455b7ad 
Migrating to V6 and Rocky8
@ek-nag
OFE: Update cluster_config.yaml.j2
8733514 
Migrating to V6 and Rocky8
@ek-nag
OFE: Update partition_config.yaml.j2
ff5e0a6 
Migrating to V6 and Rocky8
@ek-nag
OFE: Update partition_config.yaml.j2
488de8d 
Migrating to v6 and Rocky8
@ek-nag
OFE: Update ghpcfe_c2daemon.py
73b4d7a 
Migrating to v6 and Rocky8
@ek-nag
OFE: Update ghpcfe_c2daemon.py
6ad3f61 
Migrating to v6 and Rocky8
@ek-nag
OFE: Update ghpcfe_c2daemon.py
262c815 
Migrating to v6 and Rocky8
@ek-nag
OFE: Update ghpcfe_c2daemon.py
b1193d0 
Migrating to v6 and Rocky8
@scott-nag
OFE: v6 form validation
4d051d6
@ek-nag
OFE: Update cluster_config.yaml.j2
df944f4 
Migrating to V6 and Rocky8
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
490d19d
@ek-nag
Merge branch 'develop' of https://github.com/nagconsulting/hpc-toolkit …
d37cbed 
…into develop
@scott-nag
OFE: fix for reservation handling
c7d7d19
@ek-nag
OFE: Update bootstrap_compute.sh
bd8fcc7 
Lustre client install fix no longer needed
ek-nag and others added 21 commits July 11, 2024 14:11
@ek-nag
OFE: Update bootstrap_controller.sh
1065819 
Lustre client install fix no longer needed
@ek-nag
OFE: Update bootstrap_login.sh
5917b9e 
Lustre client install fix no longer needed
@ek-nag
Merge branch 'GoogleCloudPlatform:develop' into develop
b5d793b
@scott-nag
OFE: use TF 1.4 in startup script
e7be868
@scott-nag
OFE: update to show valid disk options for instance types
cc5eb26
@scott-nag
OFE: indentation
b893192
@scott-nag
OFE: indentation
0420fd9
@scott-nag
OFE: indentation
4482135
@scott-nag
Merge pull request #4 from nagconsulting/ofe-july2024-fixes
a299587 
OFE - Terraform 1.4 fix, reservations and validation of compatible disk types
@scott-nag
OFE: tweak to valid drive types
c15c6fb
@scott-nag
Merge pull request #5 from nagconsulting/ofe-drive-types-adjustment
ec258c5 
OFE: tweak to valid drive types
@scott-nag
OFE: tweak to valid drive types
f8bf905
@scott-nag
Merge pull request #6 from nagconsulting/ofe-drive-types-adjustment
348e0c2 
OFE: tweak to valid drive types
@scott-nag
OFE update
b447880
@scott-nag
Merge pull request #9 from nagconsulting/aug24-update
6d7a642 
Updating develop branch
@scott-nag
Merge branch 'develop' into ofe-aug24-update
553132f
@scott-nag
Merge pull request #10 from nagconsulting/ofe-aug24-update
4d569e5 
OFE update
@scott-nag
duplication fix
0227b90
@scott-nag
Merge pull request #11 from nagconsulting/clusters-fix
77fa8d4 
Duplication fix
@scott-nag
duplication fix
16a4c37
@scott-nag
Merge pull request #12 from nagconsulting/clusters-fix
0b54a9b 
duplication fix
@nick-stroud nick-stroud added the release-improvements Added to release notes under the "Improvements" heading. label Aug 13, 2024
@nick-stroud
Copy link
Collaborator

/gcbrun

@nick-stroud nick-stroud merged commit 12697cb into GoogleCloudPlatform:develop Aug 14, 2024
11 of 53 checks passed
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@scott-nag scott-nag

Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scott-nag @nick-stroud @rohitramu @ek-nag