Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete at most one resource policy at a time #2895

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Aug 8, 2024

  • Delete at most one resource policy at a time
  • Don't fail if some policy can't be deleted

@mr0re1 mr0re1 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Aug 8, 2024
@mr0re1 mr0re1 requested review from tpdownes and nick-stroud August 8, 2024 22:32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is hotfix to main and there is code change then we also need to roll the patch version number.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@nick-stroud nick-stroud removed their assignment Aug 9, 2024
@mr0re1 mr0re1 assigned mr0re1 and tpdownes and unassigned tpdownes and mr0re1 Aug 9, 2024
@mr0re1 mr0re1 mentioned this pull request Aug 9, 2024
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Aug 9, 2024
@mr0re1 mr0re1 merged commit 53db215 into GoogleCloudPlatform:main Aug 9, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants