Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address minor warnings and lint issues #1481

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Jun 20, 2023

A series of minor changes/fixes:

  • De-capitalize error messages in line with guidance
  • Remove a test func that has become unused

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes requested a review from nick-stroud June 20, 2023 16:00
@tpdownes tpdownes changed the title Minor changes Address minor warnings and lint issues Jun 20, 2023
@tpdownes tpdownes enabled auto-merge June 20, 2023 16:01
@tpdownes
Copy link
Member Author

I decided to remove one commit that is strictly necessary for #1467.

@tpdownes tpdownes merged commit 65344ec into GoogleCloudPlatform:develop Jun 20, 2023
@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Jun 20, 2023
@tpdownes tpdownes deleted the minor_changes branch June 20, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants