Update "google" provider in OFE from 3.x to 4.x #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to wait for #1464 before merging this PR. |
rohitramu
requested review from
cboneti and
tpdownes
and removed request for
cboneti
tpdownes
requested changes
Jun 20, 2023
tpdownes
previously approved these changes
Jun 20, 2023
|
I just realized that this has significant overlap with #1464. Please rebase your feature branch and make sure this contains only OFE-related updates. I want to re-approve in case of merge conflict. |
rohitramu
force-pushed
the
roramu/update_ofe_providers
branch
from
5b74152 to
aca60bf
Compare
tpdownes
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.