Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print advanced instructions after ghpc deploy #1463

Merged

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Jun 15, 2023

  • Print advanced instructions after ghpc deploy;
  • Change WriteDeployment to take deploymentDirectory;
  • Meet test coverage by reducing number of lines.

@mr0re1 mr0re1 requested a review from tpdownes June 15, 2023 19:10
@mr0re1 mr0re1 enabled auto-merge (squash) June 15, 2023 20:45
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following issues from user side:

  1. The instructions appear to be printed twice now when running create:
To deploy your infrastructure please run:

./ghpc deploy simple

Find instructions for cleanly destroying infrastructure and advanced manual
deployment instructions at:

simple/instructions.txt
To deploy your infrastructure please run:

./ghpc deploy simple

Find instructions for cleanly destroying infrastructure and advanced manual
deployment instructions at:

simple/instructions.txt
  1. I think some space or another delimiter (e.g. ####) is necessary when running deploy:
collecting terraform outputs from simple/first
writing outputs artifact from group first to file simple/.ghpc/artifacts/first_outputs.tfvars
Find instructions for cleanly destroying infrastructure and advanced manual
deployment instructions at:

simple/instructions.txt

@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Jun 20, 2023
@tpdownes
Copy link
Member

After you make the requested changes, please also update the description to include a "before" and "after" of what the commands look like.

* Print advanced instructions after `ghpc deploy`;
* Change `WriteDeployment` to take `deploymentDirectory`;
* Improve test coverage by reducing number of lines.
@mr0re1
Copy link
Collaborator Author

mr0re1 commented Jun 20, 2023

$ make && rm -rf hello/ && ./ghpc create tst.yaml $TOOLKIT_DEF_VARS > ~/tmp/after
$ g co develop
$ make && rm -rf hello/ && ./ghpc create tst.yaml $TOOLKIT_DEF_VARS > ~/tmp/before
$ diff ~/tmp/after ~/tmp/before
$ # no diff
$ make && ./ghpc deploy hello > ~/tmp/after
$ g co develop
$ make && ./ghpc deploy hello > ~/tmp/before
$ diff ~/tmp/after ~/tmp/before
<
< ###############################
< Find instructions for cleanly destroying infrastructure and advanced manual
< deployment instructions at:
<
< hello/instructions.txt

@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Jun 20, 2023
@mr0re1 mr0re1 force-pushed the print_instructions_deploy branch from 92129fe to af7dd22 Compare June 20, 2023 21:10
@tpdownes tpdownes self-requested a review June 20, 2023 21:12
@mr0re1 mr0re1 merged commit a49f794 into GoogleCloudPlatform:develop Jun 20, 2023
@mr0re1 mr0re1 deleted the print_instructions_deploy branch June 28, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants