Add options for create and update timeouts to gke modules #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-stroud
force-pushed
the
gke-terraform-timeouts
branch
from
959ff3a to
9247059
Compare
cboneti
approved these changes
Jun 9, 2023
soumyapani
reviewed
Jun 9, 2023
soumyapani
approved these changes
Jun 9, 2023
nick-stroud
force-pushed
the
gke-terraform-timeouts
branch
from
9247059 to
9506290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1424, node pools may take longer to create if they are also creating a large number of static nodes. This change allows users to adjust the timeout.
Manually tested with default of null and setting to value.
Submission Checklist
Please take the following actions before submitting this pull request.