Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golden copy tests for terraform IGC #1204

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Add golden copy tests for terraform IGC #1204

merged 1 commit into from
Apr 21, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Apr 21, 2023

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@mr0re1 mr0re1 requested a review from tpdownes April 21, 2023 16:50
@mr0re1
Add golden copy tests for terraform IGC
e35f278 
* Add golden copy tests for terraform IGC
* Improve usability of validate_golden_copy by printing absolute pathes
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Apr 21, 2023
@mr0re1 mr0re1 merged commit df3fbee into GoogleCloudPlatform:develop Apr 21, 2023
@mr0re1 mr0re1 deleted the gc_tf_igc branch April 21, 2023 19:19
This was referenced Apr 26, 2023
Closed
Merged
mr0re1 added a commit that referenced this pull request May 4, 2023
@mr0re1
Add golden copy tests for terraform IGC (#1204)
69465b9 
* Add golden copy tests for terraform IGC
* Improve usability of validate_golden_copy by printing absolute pathes
mr0re1 added a commit that referenced this pull request May 4, 2023
@mr0re1
Revert "Add golden copy tests for terraform IGC (#1204)"
4654768 
This reverts commit 69465b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@mr0re1 mr0re1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr0re1 @tpdownes