Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor resolution of RequiredApis into separate function, so rest c… #1194

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Refactor resolution of RequiredApis into separate function, so rest c… #1194

merged 1 commit into from
Apr 19, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Apr 19, 2023

…an be removed

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@mr0re1 mr0re1 requested a review from nick-stroud April 19, 2023 22:59
@nick-stroud nick-stroud assigned mr0re1 and unassigned nick-stroud Apr 19, 2023
@mr0re1 mr0re1 merged commit 40a9cb4 into GoogleCloudPlatform:develop Apr 19, 2023
@mr0re1 mr0re1 deleted the just_req_apis2 branch April 19, 2023 23:59
mr0re1 added a commit that referenced this pull request May 4, 2023
@mr0re1
Refactor resolution of RequiredApis into separate function, so rest c…
039a4f3 
…an be removed (#1194)
mr0re1 added a commit that referenced this pull request May 4, 2023
@mr0re1
Revert "Refactor resolution of RequiredApis into separate function, s…
a644dde 
…o rest can be removed (#1194)"

This reverts commit 039a4f3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@mr0re1 mr0re1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr0re1 @nick-stroud