Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to Expression #1192

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Minor changes to Expression #1192

merged 1 commit into from
Apr 19, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Apr 19, 2023 •
edited
Loading

  • Add Reference.AsExpression() to not leak logic of string format;
  • Fix wrong expression format in tests;
  • Add Expression.Eval(Blueprint);
  • Add Dict.Eval(Blueprint).

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@mr0re1 mr0re1 requested a review from tpdownes April 19, 2023 19:50
@mr0re1 mr0re1 assigned tpdownes and unassigned tpdownes Apr 19, 2023
@mr0re1
Minor changes to Expression
485e8e9 
* Add `Reference.AsExpression()` to not leak logic of string format;
* Fix wrong expression format in tests;
* Add `Expression.Eval(Blueprint)`;
* Add `Dict.Eval(Blueprint)`.
tpdownes
tpdownes approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Offline discussion about Reference and varReference having overlap has been resolved with understanding that varReference will be able to disappear in a soon-to-be submitted PR.

@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Apr 19, 2023
@mr0re1 mr0re1 merged commit d11a575 into GoogleCloudPlatform:develop Apr 19, 2023
@mr0re1 mr0re1 deleted the exp_as_ref branch April 19, 2023 22:51
mr0re1 added a commit that referenced this pull request May 4, 2023
@mr0re1
Minor changes to Expression (#1192)
49627b0 
* Add `Reference.AsExpression()` to not leak logic of string format;
* Fix wrong expression format in tests;
* Add `Expression.Eval(Blueprint)`;
* Add `Dict.Eval(Blueprint)`.
mr0re1 added a commit that referenced this pull request May 4, 2023
@mr0re1
Revert "Minor changes to Expression (#1192)"
de817b4 
This reverts commit 49627b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@mr0re1 mr0re1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr0re1 @tpdownes