Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SchedMD modules to 5.6.3 (from 5.6.2) #1171

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Update SchedMD modules to 5.6.3 (from 5.6.2) #1171

merged 2 commits into from
Apr 17, 2023

Conversation

SkylerMalinowski
Copy link
Contributor

@SkylerMalinowski SkylerMalinowski commented Apr 13, 2023 •
edited
Loading

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@tpdownes
Copy link
Member

/gcbrun

@cboneti cboneti self-requested a review April 13, 2023 19:13
@cboneti cboneti self-assigned this Apr 13, 2023
cboneti
cboneti requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the controller expose its newly added output? (SchedMD/slurm-gcp@be610be#diff-204625a3602feb0099fa10345ddb53424263341577cc43fd51ffef6ebfe66d0c).

@cboneti cboneti assigned SkylerMalinowski and unassigned cboneti Apr 13, 2023
@SkylerMalinowski
Copy link
Contributor Author

Exposing it on the controller would make it available for toolkit to use. For this PR there is nothing that can be done as the requested change would have to be released in a subsequent version.

@cboneti
Copy link
Member

cboneti commented Apr 17, 2023

Ok, I will merge it as is while the outputs are not available at the controller.

@cboneti cboneti merged commit 6253c2d into GoogleCloudPlatform:develop Apr 17, 2023
@SkylerMalinowski SkylerMalinowski deleted the slurm-gcp-5.6.3 branch April 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboneti cboneti cboneti approved these changes

Assignees

@SkylerMalinowski SkylerMalinowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkylerMalinowski @tpdownes @cboneti