Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent TerraformBackend.Config with cty.Value #1141

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Apr 9, 2023

  • Add Dict struct to map string ket to cty.Value and handle YAML marshal/unmarshal;
  • Use Dict instead of map[string]interface{} for TerraformBackend.Config.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@mr0re1 mr0re1 requested a review from tpdownes April 9, 2023 06:03
* Add `Dict` struct to map string ket to `cty.Value` and handle YAML marshal/unmarshal;
* Use `Dict` instead of `map[string]interface{}` for `TerraformBackend.Config`.
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix minor typos
  • address concern about old library (if there is no alternative please confirm that this isn't tying us to old packages or old version of Golang)
  • minor Qs about parsing

May not require code changes other than typos.

go.mod Show resolved Hide resolved
pkg/config/dict.go Outdated Show resolved Hide resolved
pkg/config/dict.go Outdated Show resolved Hide resolved
pkg/config/dict.go Show resolved Hide resolved
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Apr 10, 2023
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Apr 10, 2023
@tpdownes tpdownes self-requested a review April 10, 2023 22:07
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Apr 10, 2023
@mr0re1 mr0re1 merged commit 1391628 into GoogleCloudPlatform:develop Apr 10, 2023
@mr0re1 mr0re1 deleted the unmarshal_dict branch April 10, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants