Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce compatibility with native namespace packages #906

Merged
merged 4 commits into from
Nov 20, 2023
Merged

feat: introduce compatibility with native namespace packages #906

merged 4 commits into from
Nov 20, 2023

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon requested a review from a team as a code owner November 17, 2023 21:36
@jackwotherspoon jackwotherspoon self-assigned this Nov 17, 2023
enocom
enocom approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@enocom enocom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's have a Python reviewer take a look and then we can merge this.

@jackwotherspoon
Copy link
Collaborator Author

@parthea mind reviewing this PR as it is similar to those that you have done for the googleapis libraries? 😄

parthea
parthea approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the do not merge label to the release PR so this doesn't get merged during the freeze. Also, consider publishing a pre-release version with this change first to allow for additional compatibility testing.

setup.py Show resolved Hide resolved
tests/unit/test_packaging.py Outdated Show resolved Hide resolved
@jackwotherspoon jackwotherspoon added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 20, 2023
@enocom
Copy link
Member

enocom commented Nov 20, 2023

@parthea Merging this PR doesn't result in a release. Is there any reason why we shouldn't just merge this?

@parthea
Copy link
Contributor

parthea commented Nov 20, 2023 •
edited
Loading

@enocom I've blocked development PRs from being merged for python repositories in googleapis but this isn't a hard requirement. Please feel free to merge this PR, assuming that we will block the release PR. Please file a bug for the suggestion in #906 (comment) if it won't be addressed in this PR

@jackwotherspoon jackwotherspoon mentioned this pull request Nov 20, 2023
Open
@jackwotherspoon jackwotherspoon removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 20, 2023
@jackwotherspoon jackwotherspoon merged commit 083da11 into main Nov 20, 2023
16 checks passed
@jackwotherspoon jackwotherspoon deleted the deprecate-pkg-resources branch November 20, 2023 19:35
@release-please release-please bot mentioned this pull request Nov 20, 2023
Merged
@jackwotherspoon jackwotherspoon mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@enocom enocom enocom approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove declare_namespace calls in package
3 participants
@jackwotherspoon @enocom @parthea