feat: deprecate proxy drivers #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
approved these changes
Oct 22, 2022
| // | ||
| // Deprecated: Dial has been replaced by the Cloud SQL Go connector which has | ||
| // better support for configuring the dialer's behavior. | ||
| // See cloud.google.com/go/cloudsqlconn/mysql/mysql.RegisterDriver instead. |
There was a problem hiding this comment.
This seems unlikely to be seen unless someone reads the code - should we consider adding a 1 time log warning or something?
There was a problem hiding this comment.
It would be nice to put this front and center, but since we don't know how people are setting up their logging system, the best we could do is log to stdout which would be an intrusive change. I think we'll have to advertise this change in the new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.