Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 Go Connector misreports version #1836

Closed
enocom opened this issue Jun 7, 2023 · 1 comment
Closed

v1 Go Connector misreports version #1836

enocom opened this issue Jun 7, 2023 · 1 comment
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@enocom
Copy link
Member

enocom commented Jun 7, 2023 •
edited
Loading

In the v1 Go Connector, there is a hardcoded version:

https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/v1/proxy/certs/certs.go#L40

Instead, the v1 Go Connector should respect the version here:

https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/v1/cmd/cloud_sql_proxy/version.txt
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 7, 2023
annafang-google added a commit that referenced this issue Aug 11, 2023
@annafang-google
fix: replace the hardcoded default version string (#1836)
6d1fdb5 
Remove empty line
annafang-google added a commit that referenced this issue Aug 11, 2023
@annafang-google
fix: replace the hardcoded default version string (#1836)
7cf85fb 
Remove empty line

fixed cloudsqlutil.go format

fix test code
annafang-google added a commit that referenced this issue Aug 11, 2023
@annafang-google
fix: Update version.txt for v1 branch (#1836)
0c497e7
annafang-google added a commit that referenced this issue Aug 11, 2023
@annafang-google
fix: replace the hardcoded default version string (#1836)
6589ef3 
Remove empty line

fixed cloudsqlutil.go format

fix test code

Fixed the typo in the test message
annafang-google added a commit that referenced this issue Aug 15, 2023
@annafang-google
fix: replace the hardcoded default version string (#1836)
ad605cb 
Remove empty line

fixed cloudsqlutil.go format

fix test code

Fixed the typo in the test message

Fixed typo and wrapped the long line
annafang-google added a commit that referenced this issue Aug 15, 2023
@annafang-google
fix: replace the hardcoded default version string (#1836) (#1900)
f945798
annafang-google added a commit that referenced this issue Aug 15, 2023
@annafang-google
chore: update version.txt for v1 branch (#1836) (#1904)
1f56f65
@release-please release-please bot mentioned this issue Aug 15, 2023
Merged
@jackwotherspoon
Copy link
Collaborator

Fixed as part of #1904 and #1900

@release-please release-please bot mentioned this issue Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enocom @jackwotherspoon