Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy does not build on FreeBSD as of v1.27.0 release #1438

Closed
mhoran opened this issue Sep 26, 2022 · 2 comments
Closed

Proxy does not build on FreeBSD as of v1.27.0 release #1438

mhoran opened this issue Sep 26, 2022 · 2 comments
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mhoran
Copy link

mhoran commented Sep 26, 2022 •
edited
Loading

As of v1.27.0, the cloud-sql-proxy fails to build on FreeBSD. It seems that github.com/hanwen/go-fuse does not work on this operating system. The build fails as follows:

# github.com/hanwen/go-fuse/v2/fuse
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/types.go:550:2: undefined: Attr
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/types.go:578:2: undefined: Attr
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:224:41: undefined: GetAttrIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:225:41: undefined: SetAttrIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:228:39: undefined: MknodIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:252:42: undefined: SetXAttrIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:258:40: undefined: CreateIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:260:38: undefined: ReadIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:269:39: undefined: WriteIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:278:41: undefined: ReadIn
go/pkg/mod/github.com/hanwen/go-fuse/[email protected]/fuse/api.go:278:41: too many errors

Rolling back to v1.26.0 builds fine.
@mhoran mhoran added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 26, 2022
@mhoran mhoran changed the title Proxy does not build on FreeBSD as of preview.1 release Proxy does not build on FreeBSD as of v1.27.0 release Sep 26, 2022
@enocom enocom added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Sep 26, 2022
@enocom
Copy link
Member

enocom commented Sep 26, 2022 •
edited
Loading

Thanks for the report @mhoran. I'm surprised that go-fuse doesn't support FreeBSD. Nonetheless, we'll put this behind a build constraint in the next release (and preview release, as that is likely affected too).

enocom added a commit that referenced this issue Sep 26, 2022
@enocom
fix: don't build fuse on freebsd
41922c7 
Fixes #1438.
@enocom enocom mentioned this issue Sep 26, 2022
Merged
enocom added a commit that referenced this issue Sep 26, 2022
@enocom
fix: restore openbsd and freebsd support
fd6c44e 
Related to #1438.
@enocom enocom mentioned this issue Sep 26, 2022
Merged
enocom added a commit that referenced this issue Sep 27, 2022
@enocom
fix: don't build fuse on freebsd (#1439)
87863a1 
Fixes #1438.
@enocom enocom closed this as completed Sep 27, 2022
enocom added a commit that referenced this issue Sep 27, 2022
@enocom
fix: restore openbsd and freebsd support (#1442)
05dcdd4 
Related to #1438.
@enocom
Copy link
Member

enocom commented Sep 27, 2022

We will get this out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoran @enocom