This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
fix: Explicitly create SLO services when installation with ASM is launched #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify and apply kustomize config in a temp folder instead of using in-place changes.
fix error behavior of collecting public IP when ASM is installed.
because known SLO services are no longer auto-created, add provisioning of SLO services. use CLUSTER_ISTIO as service type. modify SLO provisioning to use the new added resource. modify alert provisioning to use the added SLO services resources. add location parameter to monitoring module.
Refresh the list of input arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify terraform to add explicit SLO service provisioning. In the past, deploying Istio services result in automatic creation of matching SLO services. The recent change in behavior resulted in the installation process running forever while waiting for SLO services to be available.
The change configures terraform (in
slo_services.tf) to provision SLO service instances and makes additional changes to use the new resources instead of data that was generated byslo_servicemodule.This change will be available in the version 0.9.4
🛠️ Fixes #1063