Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade google-auth-library-bom to 0.25.0 #1987

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Upgrade google-auth-library-bom to 0.25.0 #1987

merged 1 commit into from
Mar 17, 2021

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Mar 17, 2021

For googleapis/gax-java#1302, which fails Linkage Monitor.

CC: @arithmetic1728

@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@suztomo suztomo requested a review from elharo March 17, 2021 20:53
@suztomo suztomo merged commit 7efed10 into master Mar 17, 2021
@suztomo suztomo deleted the auth_upgrade branch March 17, 2021 21:57
@suztomo
Copy link
Contributor Author

suztomo commented Mar 17, 2021

The BOM in the master branch does not affect Linkage Monitor check (It's different from the upper bound check).

The check still fails

SEVERE: Newly introduced problem:
(com.google.auth:google-auth-library-oauth2-http:0.24.1) com.google.auth.oauth2.GoogleCredentials's method createScoped(java.util.Collection, java.util.Collection) is not found
  referenced from com.google.api.gax.core.GoogleCredentialsProvider (com.google.api:gax:1.62.1-SNAPSHOT)

I think I'll need another release for this change to make the change pass.

@suztomo suztomo mentioned this pull request Mar 18, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @elharo