Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manager role in cloud identity group module #787

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Aug 31, 2022

Add support for MANAGERS role.
Associated bug is fixed: hashicorp/terraform-provider-google#7616

@lcaggio lcaggio marked this pull request as ready for review August 31, 2022 09:35
@lcaggio lcaggio requested review from juliocc and sruffilli August 31, 2022 09:35
@ludoo ludoo changed the title Add support for MANAGERS role Support manager role in cloud identity group module Aug 31, 2022
@sruffilli
Copy link
Collaborator

Hey Lorenzo - just to be on the safe side, have you tried re-triggering the aforementioned issue?

@lcaggio
Copy link
Collaborator Author

lcaggio commented Aug 31, 2022

I did the following test:

  • Created a group with 1 MEMBER and 1 MANAGER
  • Moved the MANAGER user to MEMEBR
  • Moved back the MEMBER to MANAGER

The test worked with no error. Does it trigger the use case mentioned in the issue?

Additional note: since the MANAGER is also a MEMBER, I added the depends_on attribute you find here.

@lcaggio lcaggio merged commit 1c677d0 into master Aug 31, 2022
@lcaggio lcaggio deleted the lcaggio/groups branch August 31, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a google_cloud_identity_group_membership to remove a role fails with an error
3 participants