Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret manager flag sensitive output #786

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

ddaluka
Copy link
Contributor

@ddaluka ddaluka commented Aug 29, 2022

Secret manager module output (versions) contains sensitive value and without that flag, terraform init and plan throws error. I have added the sensitive flag for that output in that module.

@google-cla
Copy link

google-cla bot commented Aug 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Aug 29, 2022

Thanks for this! Can you run the tfdoc tool as explained in the last section of our contributing guidelines? That will fix the linting error.

@juliocc
Copy link
Collaborator

juliocc commented Aug 29, 2022

Hi @ddaluka thanks for the fix!

Can you run tfdoc against the module (see CONTRIBUTING.md for details)?

@juliocc
Copy link
Collaborator

juliocc commented Aug 29, 2022

You still have some linting errors. Don't change the file manually, run tfdoc and it will update the file.

@ludoo ludoo merged commit 16e14fd into GoogleCloudPlatform:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants