Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to multiple READMEs #740

Merged
merged 30 commits into from
Aug 11, 2022
Merged

Update to multiple READMEs #740

merged 30 commits into from
Aug 11, 2022

Conversation

bluPhy
Copy link
Collaborator

@bluPhy bluPhy commented Jul 15, 2022

Update to multiple READMEs, wording and spelling

@ludoo
Copy link
Collaborator

ludoo commented Jul 15, 2022

This is great, thanks a lot for taking the time! Let's wait for checks then we can merge at once.

@ludoo
Copy link
Collaborator

ludoo commented Jul 15, 2022

Hah, ok linting: you should not update the variables tables in the docs, but update the variable description in the tf files then re-run tfdoc. Instructions are in or contributing doc. Can you do that? Or remove the variable fixes and we'll do them separately.

@juliocc
Copy link
Collaborator

juliocc commented Aug 8, 2022

@bluPhy can you rebase, fix the conflicts, and run tfdoc as mentioned by @ludoo?

Thanks

@ludoo ludoo merged commit a85f3aa into GoogleCloudPlatform:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants