Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: fix Gitlab WIF attributes #671

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 9, 2022

This removes unsupported attributes and adds supported ones to the Gitlab mapping used for Workload Identity Federation pools.

Tested with the following condition:

cicd_repositories = {
  bootstrap = {
    branch            = "main"
    identity_provider = "gitlab-ludomagno"
    name              = "ludomagno/fast-test"
    type              = "gitlab"
  }
}
federated_identity_providers = {
  gitlab-ludomagno = {
    attribute_condition = "attribute.namespace_path==\"ludomagno\""
    issuer              = "gitlab"
  }
}

@ludoo ludoo requested review from amgoogle, juliocc and sruffilli June 9, 2022 06:03
@ludoo ludoo merged commit bb3f55f into master Jun 9, 2022
@ludoo ludoo deleted the ludo/fast-wif-gitlab-attributes branch June 9, 2022 06:31
@ludoo ludoo changed the title Fix Gitlab WIF attributes FAST: Fix Gitlab WIF attributes Jun 10, 2022
lcaggio pushed a commit that referenced this pull request Jun 17, 2022
@ludoo ludoo changed the title FAST: Fix Gitlab WIF attributes FAST: fix Gitlab WIF attributes Jul 31, 2022
@ludoo ludoo added the on:FAST label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants