-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible stage 2s in FAST resource manager #2840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c342def
to
986a2ac
Compare
* Add principal interpolation to iam_by_principals * Fix tests
juliocc
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR.
I'll start drafting something to document the schemas in a more human-friendly way. We should also document where interpolation happens
karpok78
pushed a commit
to karpok78/cloud-foundation-fabric
that referenced
this pull request
Feb 8, 2025
* wip * WIP * wip * wip * apply untested * tests * support tag expansion for tenant-level installations in IAM conditions * fix stage config output * inventories * remove dev files * tfdoc * enable org policies for stage folders * resman README * tfdoc * stage 3 documentation * inventory * support extra_dirs in testing franework * remove org policy files from stage 1 * Add principal interpolation to iam_by_principals (GoogleCloudPlatform#2847) * Add principal interpolation to iam_by_principals * Fix tests * relax schemas * relax schemas --------- Co-authored-by: Julio Castillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements flexible stage 2s in the FAST resource manager stage, where stage 2 can now be arbitrarily defined via the
fast_stage_2
variable or the associated factory.Points of note:
-ro
andrw
instead of using-r
for the read-only service account, so as to match what is used in the YAML filesStage IAM is now explicit, instead of scattered across code files, and can be tweaked without code changes:
iam_
attributes for its own folder and the organizationiam_bindings
, e.g. the delegated role grant for the project factoriesstage3_config
attribute, instead of in the stage 3 itself like beforeExamples of the above IAM configurations from the factory file for the networking stage.
Folder config and folder-level IAM, which now follow our standard IAM interface and should be pretty intuitive:
Organization-level IAM, also following our standard interface:
Cross-stage IAM for other stage 2 (project factory delegated grant), now also explicit and tweakable:
Cross-stage IAM for stage 3:
TODO: