Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket IAM policy read #2838

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

karpok78
Copy link

Allow the Project factory read only SA to retrieve buckets IAM policy for buckets created by the PF
PR rebuilt on top of a clean fast-dev version


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Allow the Project factory read only SA to retrieve buckets IAM policy for buckets created by the PF
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

@karpok78
Copy link
Author

This will allow the project factory CICD read only account to retrieve ram policy for the bucket under the PF management.
This prevents failure during the plan phase of the CICD workflow

@juliocc
Copy link
Collaborator

juliocc commented Feb 3, 2025

This can probably be implemented better now that we have interpolation for IAM conditions. Please check the latest code in the fast-dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants