Rodriguezsergio/fix https proxy resource #2779
Conversation
|
Can you please provide a repro of what exactly is breaking, and the error message? |
|
And did you check if this is merged in your branch? |
rodriguezsergio
force-pushed
the
rodriguezsergio/fix-https-proxy-resource
branch
from
d15c08b to
01e34c3
Compare
|
@ludoo it looks like someone beat me to it for that single directory. I will rebase against main and adopt that style change across all My first attempt was here #2665 but I got caught up with my day job. I'm in the process of verifying that all tests pass now (e2e tests excluded). Are non-google contributors expected to run e2e tests? |
rodriguezsergio
force-pushed
the
rodriguezsergio/fix-https-proxy-resource
branch
from
e4a8579 to
ff72c38
Compare
| @@ -215,7 +215,6 @@ values: | |||
| description: Terraform managed. | |||
| enable_cdn: null | |||
| failover_policy: [] | |||
| iap: [] | |||
There was a problem hiding this comment.
This error kept popping up for me. If this is not the right way to address this, please let me know.
================================================================= short test summary info =================================================================
FAILED tests/examples/test_plan.py::test_example[terraform:modules/net-lb-ext:Referencing existing MIGs:1] - AssertionError: tests/modules/net_lb_ext/examples/migs.yaml: .module.nlb.google_compute_region_backend_service.default.iap is not a valid address in t...
FAILED tests/examples/test_plan.py::test_example[terraform:modules/net-lb-ext:Externally managed instances:1] - AssertionError: tests/modules/net_lb_ext/examples/ext_migs.yaml: .module.nlb.google_compute_region_backend_service.default.iap is not a valid address ...
FAILED tests/examples/test_plan.py::test_example[terraform:modules/net-lb-ext:Multiple forwarding rules:1] - AssertionError: tests/modules/net_lb_ext/examples/fwd_rules.yaml: .module.nlb.google_compute_region_backend_service.default.iap is not a valid address...
FAILED tests/examples/test_plan.py::test_example[terraform:modules/net-lb-ext:Dual stack (IPv4 and IPv6):1] - AssertionError: tests/modules/net_lb_ext/examples/dual_stack.yaml: .module.nlb.google_compute_region_backend_service.default.iap is not a valid addres...
FAILED tests/examples/test_plan.py::test_example[terraform:modules/net-lb-ext:End to end example:1] - AssertionError: tests/modules/net_lb_ext/examples/e2e.yaml: .module.nlb.google_compute_region_backend_service.default.iap is not a valid address in th...
====================================================== 5 failed, 978 deselected in 113.49s (0:01:53) ======================================================
"ssl_certificates" and "certificate_manager_certificates" are mutually exclusive.
the other folders in this directory are using "group" not "backend". Keep things standardized to make future updates easier.
certificate_manager_certificates CAN be null Fixes pytest error from Terraform plan: - "certificate_manager_certificates": conflicts with ssl_certificates
rodriguezsergio
force-pushed
the
rodriguezsergio/fix-https-proxy-resource
branch
from
df72d50 to
4deff4f
Compare
| @@ -31,8 +31,7 @@ variable "backend_service_configs" { | |||
| session_affinity = optional(string) | |||
| timeout_sec = optional(number) | |||
| backends = list(object({ | |||
| # group renamed to backend | |||
| backend = string | |||
| group = string | |||
There was a problem hiding this comment.
The names are not consistent across modules.
There are missing properties across modules as well. Can you elaborate why standardizing on 1 name is not advised?
There was a problem hiding this comment.
Some properties are missing because different load balancera support different features.
I would not touch those modules, they are very complex and delicate and have worked well for a long time.
|
I am closing this, if you reopen can you please
Thanks :) |
My local copy of this repo at this commit fails during a Terraform plan when I define a value for
https_proxy_config.certificate_manager_certificates.This PR fixes that in not only
net-lb-app-int, but a few other directories.I did NOT run e2e tests. I looped through the affected directories and ran the following
Checklist
If applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py