Bug fix to allow applications to add Jetty servlets and filters. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Mar 22, 2024
| @@ -104,12 +106,21 @@ public void start(String serverInfo, ServletEngineAdapter.Config runtimeOptions) | |||
| threadPool.setVirtualThreadsExecutor(VirtualThreads.getDefaultVirtualThreadsExecutor()); | |||
| logger.atInfo().log("Configuring Appengine web server virtual threads."); | |||
| } | |||
|
|
|||
| // The server.getDefaultStyleSheet() returns is returning null because of some classloading issue, | |||
There was a problem hiding this comment.
Can you be either more or less vague than "some classloading issue"
There was a problem hiding this comment.
Turned this into a TODO to investigate why we need to do this, otherwise I could just remove the comment all together.
...l_jetty12/src/main/java/com/google/apphosting/runtime/jetty/ee10/AppEngineWebAppContext.java
Show resolved
Hide resolved
|
@lachlan-roberts the issue is that jetty-9 had a startWebapp() method that allowed interception of startup after metadata.resolve. |
|
@lachlan-roberts I have opened jetty/jetty.project#11553 |
gregw
approved these changes
Apr 23, 2024
ludoch
approved these changes
Apr 24, 2024
...l_jetty12/src/main/java/com/google/apphosting/runtime/jetty/ee10/AppEngineWebAppContext.java
Show resolved
Hide resolved
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…loading PiperOrigin-RevId: 627582402 Change-Id: Ib2ff3d4d9af285738adf92ffe3bc90014338982f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetty Servlets like the
DefaultServletrequire classes contained inruntime-impl-jetty12.jarto run so it can't be done by the application classloader.The logic inside
AppEngineWebAppContext.startContextis being run before the processing ofweb.xmland so the Jetty servlets were not being instantiated. I used a hack with aListenerHolder.doStartto get around this but maybe there is some better interception point for this.Also
server.getDefaultStyleSheet()was returning null due to some classloader behaviour causing the default servlet not to start. So I also have a workaround for this.