Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update install_admin_cluster.sh #776

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

dwatrous
Copy link
Contributor

@dwatrous dwatrous commented Feb 5, 2025

Description

General updates

Change summary

  • Fix some typos
  • root login was not working, so I changed to login as a user and change to root
  • ensure appropriate permissions exist to be able to write the ssh key as metadata

Ensure metadata privileges exist, fix some typos and login as a user then change to root
@dwatrous dwatrous requested review from yoshi-approver and a team as code owners February 5, 2025 16:43
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 5, 2025
@apeabody apeabody changed the title Update install_admin_cluster.sh fix: update install_admin_cluster.sh Feb 5, 2025
@apeabody
Copy link
Collaborator

apeabody commented Feb 5, 2025

Thanks @dwatrous! From the Linter:

Running shellcheck

In ./anthos-bm-gcp-bash/install_admin_cluster.sh line 130:
  --member="serviceAccount:$(gcloud projects describe $PROJECT_ID --format="value(projectNumber)")[email protected]" \
                                                      ^---------^ SC2086: Double quote to prevent globbing and word splitting.


In ./anthos-bm-gcp-bash/install_admin_cluster.sh line 133:
  --member="serviceAccount:$(gcloud projects describe $PROJECT_ID --format="value(projectNumber)")[email protected]" \
                                                      ^---------^ SC2086: Double quote to prevent globbing and word splitting.


In ./anthos-bm-gcp-bash/install_admin_cluster.sh line 136:
  --member="serviceAccount:$(gcloud projects describe $PROJECT_ID --format="value(projectNumber)")[email protected]" \
                                                      ^---------^ SC2086: Double quote to prevent globbing and word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

@apeabody
Copy link
Collaborator

apeabody commented Feb 5, 2025

/gcbrun

add double quotes to prevent globbing
@apeabody
Copy link
Collaborator

apeabody commented Feb 6, 2025

/gcbrun

@dwatrous
Copy link
Contributor Author

I updated the file based on Linter feedback.

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dwatrous!

@apeabody apeabody merged commit 6d20450 into GoogleCloudPlatform:main Feb 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants