Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Microsoft's OpenJDK package #5252

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Added Support for Microsoft's OpenJDK package #5252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions perfkitbenchmarker/linux_packages/openjdk_msft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# linux_packages/openjdk_msft.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling nit: Can you add the usual copyright block (see another file, e,g, aerospike_client.py, for example. you just need to update the year) at the top?
After that, add a docstring such as
"""Module to install Microsoft's OpenJDK package."""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to pull this change in for now. Feel free to open another pull request to add the docstring and copyright block.



def AptInstall(vm):
"""
Installs Microsoft Build of OpenJDK on an Ubuntu-based VM.

Args:
vm: The VM instance where the OpenJDK should be installed.
"""
vm.RemoteCommand('ubuntu_release=$(lsb_release -rs)')

vm.RemoteCommand(
'wget https://packages.microsoft.com/config/ubuntu/${ubuntu_release}/packages-microsoft-prod.deb'
' -O packages-microsoft-prod.deb'
)
vm.RemoteCommand('sudo dpkg -i packages-microsoft-prod.deb')

vm.RemoteCommand('sudo apt-get install -y apt-transport-https')
vm.RemoteCommand('sudo apt-get update')
vm.RemoteCommand('sudo apt-get install -y msopenjdk-21')

vm.RemoteCommand('java -version')


def YumInstall(vm):
"""
Installs Microsoft Build of OpenJDK on a RHEL/CentOS-based VM.

Args:
vm: The VM instance where the OpenJDK should be installed.
"""
vm.RemoteCommand('sudo yum install -y wget')
vm.RemoteCommand(
'sudo rpm --import https://packages.microsoft.com/keys/microsoft.asc'
)
vm.RemoteCommand(
'wget https://packages.microsoft.com/config/rhel/7/prod.repo -O'
' /etc/yum.repos.d/microsoft.repo'
)
vm.RemoteCommand('sudo yum update -y')

vm.RemoteCommand('sudo yum install -y msopenjdk-17')

vm.RemoteCommand('java -version')