-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add temp project and dataset id config properties #2034
Open
Emrehzl94
wants to merge
29
commits into
GoogleCloudPlatform:main
Choose a base branch
from
Emrehzl94:temp-project-and-dataset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add temp project and dataset id config properties #2034
Emrehzl94
wants to merge
29
commits into
GoogleCloudPlatform:main
from
Emrehzl94:temp-project-and-dataset
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emrehzl94
force-pushed
the
temp-project-and-dataset
branch
2 times, most recently
from
November 27, 2024 15:49
3ff3d4b
to
82ad817
Compare
fbiville
reviewed
Nov 27, 2024
...m/google/cloud/teleport/v2/neo4j/model/validation/BigQuerySourceProjectDatasetValidator.java
Outdated
Show resolved
Hide resolved
...-to-neo4j/src/main/java/com/google/cloud/teleport/v2/neo4j/model/sources/BigQuerySource.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
============================================
+ Coverage 45.51% 45.58% +0.07%
- Complexity 3704 3733 +29
============================================
Files 845 848 +3
Lines 50084 50214 +130
Branches 5268 5275 +7
============================================
+ Hits 22794 22891 +97
- Misses 25618 25650 +32
- Partials 1672 1673 +1
|
Emrehzl94
force-pushed
the
temp-project-and-dataset
branch
from
November 28, 2024 13:56
76b0c94
to
e05550d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
temp_data_beam_project
andtemp_data_beam_dataset
configuration properties, allowing temporary data to be written to a specified project and dataset ID for the BigQuery source.