Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add temp project and dataset id config properties #2034

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Emrehzl94
Copy link
Contributor

@Emrehzl94 Emrehzl94 commented Nov 26, 2024

This PR introduces temp_data_beam_project and temp_data_beam_dataset configuration properties, allowing temporary data to be written to a specified project and dataset ID for the BigQuery source.

@Emrehzl94 Emrehzl94 force-pushed the temp-project-and-dataset branch 2 times, most recently from 3ff3d4b to 82ad817 Compare November 27, 2024 15:49
@Emrehzl94 Emrehzl94 marked this pull request as ready for review November 27, 2024 15:52
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 35 lines in your changes missing coverage. Please review.

Project coverage is 45.58%. Comparing base (046865d) to head (82ad817).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...port/v2/neo4j/providers/bigquery/BqQueryToRow.java 0.00% 12 Missing ⚠️
.../teleport/v2/neo4j/model/helpers/BigQuerySpec.java 0.00% 11 Missing ⚠️
...port/v2/neo4j/providers/bigquery/BigQueryImpl.java 0.00% 10 Missing ⚠️
...eleport/v2/neo4j/model/sources/BigQuerySource.java 87.50% 1 Missing ⚠️
...idation/BigQuerySourceProjectDatasetValidator.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2034      +/-   ##
============================================
+ Coverage     45.51%   45.58%   +0.07%     
- Complexity     3704     3733      +29     
============================================
  Files           845      848       +3     
  Lines         50084    50214     +130     
  Branches       5268     5275       +7     
============================================
+ Hits          22794    22891      +97     
- Misses        25618    25650      +32     
- Partials       1672     1673       +1     
Components Coverage Δ
spanner-templates 67.03% <78.31%> (+0.12%) ⬆️
spanner-import-export 64.24% <ø> (+0.04%) ⬆️
spanner-live-forward-migration 75.91% <ø> (+0.02%) ⬆️
spanner-live-reverse-replication 76.87% <78.31%> (+0.22%) ⬆️
spanner-bulk-migration 86.56% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...v2/neo4j/model/sources/BigQuerySourceProvider.java 100.00% <100.00%> (ø)
...eleport/v2/neo4j/model/sources/BigQuerySource.java 61.90% <87.50%> (+15.23%) ⬆️
...idation/BigQuerySourceProjectDatasetValidator.java 92.30% <92.30%> (ø)
...port/v2/neo4j/providers/bigquery/BigQueryImpl.java 0.00% <0.00%> (ø)
.../teleport/v2/neo4j/model/helpers/BigQuerySpec.java 0.00% <0.00%> (ø)
...port/v2/neo4j/providers/bigquery/BqQueryToRow.java 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants