-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URLs for import into DevSite #1974
Open
rszper
wants to merge
18
commits into
GoogleCloudPlatform:main
Choose a base branch
from
rszper:rszper-codeStrings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rszper
commented
Oct 29, 2024
- Add code tags to URLs that are examples and aren't meant to resolve. Currently, when imported to DevSite, these URLs are turned into links. The code tags make them examples instead of links.
- Fix broken neo4j link.
- Minor text updates.
Add code markers around the sample URL so that it renders as an example rather than as a URL when it's imported to DevSite.
Update ImportPipeline.java
Add code marking around examples URLs.
Fix broken URL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
Coverage 45.08% 45.09%
- Complexity 3608 3936 +328
==========================================
Files 835 835
Lines 49693 49703 +10
Branches 5230 5232 +2
==========================================
+ Hits 22406 22415 +9
- Misses 25620 25622 +2
+ Partials 1667 1666 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.