Add open() API with FileStatus #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFileSystem.java
Show resolved
Hide resolved
gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFileSystem.java
Show resolved
Hide resolved
| public FSDataInputStream open(FileStatus status) throws IOException { | ||
| logger.atFine().log("openWithStatus(%s)", status); | ||
|
|
||
| GoogleHadoopFileStatus fileStatus = (GoogleHadoopFileStatus) status; |
There was a problem hiding this comment.
Wouldn't it be casting issue?
There was a problem hiding this comment.
Caller will have to handle the exception.
There was a problem hiding this comment.
It would be better to validate and throw IllegalArgument instead of throwing type cast exception from API?
gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFileSystem.java
Show resolved
Hide resolved
gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFileSystem.java
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
singhravidutt
approved these changes
Sep 9, 2024
| public FSDataInputStream open(FileStatus status) throws IOException { | ||
| logger.atFine().log("openWithStatus(%s)", status); | ||
|
|
||
| if (!GoogleHadoopFileStatus.class.isAssignableFrom(status.getClass())) { |
There was a problem hiding this comment.
isInstanceOf would have sufficed, no?
arunkumarchacko
merged commit 7ad304c
into
GoogleCloudDataproc:branch-3.0.x
3 of 4 checks passed
arunkumarchacko
added a commit
to arunkumarchacko/hadoop-connectors
that referenced
this pull request
Sep 9, 2024
arunkumarchacko
added a commit
to arunkumarchacko/hadoop-connectors
that referenced
this pull request
Sep 9, 2024
arunkumarchacko
added a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.