Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc gcs statistics support #1158

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

singhravidutt
Copy link
Contributor

gRPC interceptor to capture GoogleCloudStorageStatistics.

@singhravidutt
Copy link
Contributor Author

/gcbrun

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (ea37b8b) to head (a279d99).

Files Patch % Lines
...gle/cloud/hadoop/fs/gcs/GhfsStorageStatistics.java 50.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             branch-2.2.x    #1158      +/-   ##
==================================================
- Coverage           80.85%   80.76%   -0.09%     
- Complexity           2368     2373       +5     
==================================================
  Files                 164      166       +2     
  Lines               10716    10746      +30     
  Branches             1194     1194              
==================================================
+ Hits                 8664     8679      +15     
- Misses               1531     1542      +11     
- Partials              521      525       +4     
Flag Coverage Δ
hadoop2integrationtest 64.08% <65.71%> (+0.03%) ⬆️
hadoop2unittest 66.61% <48.57%> (-0.12%) ⬇️
hadoop3integrationtest 63.96% <65.71%> (?)
hadoop3unittest 66.67% <48.57%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@singhravidutt singhravidutt requested review from guljain and arunkumarchacko and removed request for guljain May 17, 2024 07:58
@singhravidutt singhravidutt marked this pull request as ready for review May 17, 2024 07:58
@singhravidutt singhravidutt requested a review from guljain May 17, 2024 08:03
@singhravidutt singhravidutt merged commit 111dc43 into branch-2.2.x Jun 5, 2024
2 of 4 checks passed
@singhravidutt singhravidutt deleted the grpcInterceptor branch June 5, 2024 14:13
singhravidutt added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants