fix: terminate s8s session on kernel termination #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsidhom
reviewed
Jan 22, 2025
medb
requested changes
Jan 22, 2025
ojarjur
reviewed
Jan 23, 2025
ojarjur
reviewed
Jan 23, 2025
Comment on lines
546
to
547
| if state is not None and state == Session.State.FAILED: | ||
| raise RuntimeError("Serverless session termination failed") |
There was a problem hiding this comment.
Instead of this logic with the state = None statement above, put a return statement outside of the while loop on line 540, and then make the subsequent raise RuntimeError... call below unconditional.
There was a problem hiding this comment.
We only want to raise RuntimeError when state == Session.State.FAILED. After the while loop if the state is failed, we need to raise this error.
medb
approved these changes
Jan 23, 2025
bsidhom
reviewed
Jan 23, 2025
bsidhom
requested changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.