Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a CLI encConfig error #1253

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ant1597
Copy link

@ant1597 ant1597 commented Jun 10, 2022

When running the following command

squoosh-cli --mozjpeg -d .\out\ .\in\

Node.js returns a TypeError:

TypeError: encParam.toLowerCase is not a function
    at Command.processFiles (file:///C:/Users/Admin/AppData/Roaming/npm/node_modules/@squoosh/cli/src/index.js:172:18)

System: Windows 10
Node.js version: 16.13.1

I have not digged into this issue, but according to a Stack Overflow discussion on a similar issue in React.js, here should have a toString() method before toLowercase() method. I hope I got it correctly.

Node.js returns a `TypeError: encParam.toLowerCase is not a function` on this line
@google-cla
Copy link

google-cla bot commented Jun 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ziemek99
Copy link
Contributor

Should be closed because of #1321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants